Function arguments (2 or fewer ideally)

[peter-gribanov]

Link to section.

A little strange.

In Bad example, the createMenu() function has 4 required dependencies ($title, $body, $buttonText, $cancellable).

In Good example, the createMenu() function has only 1 required dependency (MenuConfig).
But MenuConfig does not have required dependencies.
This means that we do not have guarantees that all the necessary dependencies will be in createMenu() function.

This means that the Good example does not solve the problems in the Bad example.

[yuriyzinchenko]

@peter-gribanov It's a good point. I think that solution is to use private properties, setters and typed getters. E.g.

class MenuConfig
{
    private $title;
    private $body;
    private $buttonText;
    private $cancellable = false;

    public function getTitle(): string
    {
        return $this->title;
    }

    public function setTitle(string $title): void
    {
        $this->title = $title;
    }

    public function getBody(): string
    {
        return $this->body;
    }

    public function setBody(string $body): void
    {
        $this->body = $body;
    }

    public function getButtonText(): string
    {
        return $this->buttonText;
    }

    public function setButtonText(string $buttonText): void
    {
        $this->buttonText = $buttonText;
    }

    public function getCancellable(): bool
    {
        return $this->cancellable;
    }

    public function setCancellable(bool $cancellable): void
    {
        $this->cancellable = $cancellable;
    }

}

It means that if required properties(title, body, buttonText) are not set the TypeError exception will be thrown. But if optional property isn't set all will be ok and default value will be returned.

[peter-gribanov]

@yuriyzinchenko Yes, by adding access methods we return control over the data types.
You can make a PR for fix it.

[peter-gribanov]

This issue was about the problem of required properties, but i now looked more closely and realized that there was no problem. Sorry.