-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bug that rollback stage was using a wrong manifests path #1011
Conversation
@@ -379,7 +380,11 @@ func (s *scheduler) executeStage(sig executor.StopSignal, ps model.PipelineStage | |||
} | |||
|
|||
// Ensure that all needed things has been prepared before executing any stage. | |||
if err := s.ensurePreparing(ctx, lp); err != nil { | |||
var ( | |||
needTargetCommit = ps.Name != model.StageRollback.String() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need the target commit for the rollback stage.
@@ -162,8 +162,15 @@ func (e *Executor) loadRunningManifests(ctx context.Context) (manifests []provid | |||
|
|||
// When the manifests were not in the cache we have to load them. | |||
var ( | |||
appDir = filepath.Join(e.RepoDir, e.Deployment.GitPath.Path) | |||
p = provider.NewProvider(e.Deployment.ApplicationName, appDir, e.RunningRepoDir, e.Deployment.GitPath.ConfigFilename, e.config.Input, e.Logger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appDir -> runningAppDir (current commit -> latest commit)
Code coverage for golang is
|
Thank you! |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
/cc @nakabonne