Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify control-plane by merging api and web into a single server component #1013

Merged
merged 5 commits into from
Oct 26, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Oct 23, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #976

Does this PR introduce a user-facing change?:

Simplify control-plane by merging api and web into a single server component

@pipecd-bot pipecd-bot added size/XL and removed size/L labels Oct 23, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 27.24%. This pull request does not change code coverage.

@nakabonne
Copy link
Member

Thanks for the great job. We just wanted to do it as soon as possible:-)

Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge "api" + "web" into a new "server" to reduce the component number of control-plane
3 participants