Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deployment config file form #1148

Merged
merged 1 commit into from Nov 26, 2020

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.96%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 83.78%. This pull request decreases coverage by -0.39%.

File Base Head Diff
src/components/application-detail.tsx 100.00% 95.92% -4.08%
src/modules/applications-live-state.ts 65.22% 66.67% +1.45%
src/modules/applications.ts 89.13% 85.71% -3.42%
src/pages/applications/detail.tsx 100.00% 84.62% -15.38%

@nghialv
Copy link
Member

nghialv commented Nov 26, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit c04b4f4 into master Nov 26, 2020
@pipecd-bot pipecd-bot deleted the refactor-deployment-config-form branch November 26, 2020 12:47
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants