Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename range_to to data_point_count #1187

Merged
merged 1 commit into from Dec 4, 2020

Conversation

sanposhiho
Copy link
Member

What this PR does / why we need it:

rename range_to to data_point_countto simplify handling time on the server side.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nakabonne
Copy link
Member

/cc @cakecatz @nghialv

@nakabonne
Copy link
Member

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Dec 4, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.27%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Dec 4, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 1097168 into master Dec 4, 2020
@pipecd-bot pipecd-bot deleted the rename-range_to-to-data_point_count branch December 4, 2020 02:43
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants