Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site chart template #1194

Merged
merged 1 commit into from Dec 7, 2020
Merged

Update site chart template #1194

merged 1 commit into from Dec 7, 2020

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

The current template lead to annotations: <invalid Value> config in case .Values.backendConfig.enabled value not set.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202
Copy link
Member Author

/cc @nghialv 🙏

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.27%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Dec 7, 2020

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit ffd6712 into master Dec 7, 2020
@pipecd-bot pipecd-bot deleted the update-site-chart branch December 7, 2020 02:52
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants