Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GetDeployment and GetCommand rpcs for external api #1231

Merged
merged 1 commit into from Dec 10, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Dec 10, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1147

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.75%. This pull request decreases coverage by -0.05%.

File Function Base Head Diff
pkg/app/api/grpcapi/utils.go getDeployment -- 57.14% +57.14%
pkg/app/api/grpcapi/utils.go getCommand -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.GetCommand 0.00% 0.00% +0.00%
pkg/app/api/grpcapi/api.go API.GetDeployment 0.00% 0.00% +0.00%
pkg/app/api/grpcapi/api.go API.GetCommand 0.00% 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.CancelDeployment 0.00% 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.getDeployment 57.14% -- -57.14%

@khanhtc1202
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit f1bd3ab into master Dec 10, 2020
@pipecd-bot pipecd-bot deleted the external-api branch December 10, 2020 06:54
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide api for external service, command line tool
3 participants