Refactor CLI to use the original deployment status #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage for golang is |
khanhtc1202
reviewed
Dec 14, 2020
| @@ -59,7 +59,7 @@ func newSyncCommand(root *command) *cobra.Command { | |||
| } | |||
|
|
|||
| func (c *sync) run(ctx context.Context, t cli.Telemetry) error { | |||
| statuses, err := makeStatuses(c.status) | |||
| statuses, err := model.DeploymentStatusesFromStrings(c.status) | |||
There was a problem hiding this comment.
nit: not in the scope of this PR but should we rename this s.status to s.statuses since it's type []string 👀
There was a problem hiding this comment.
Nice catch! Let me fix them in this too.
khanhtc1202
reviewed
Dec 14, 2020
| @@ -60,7 +60,7 @@ func newWaitStatusCommand(root *command) *cobra.Command { | |||
| } | |||
|
|
|||
| func (c *waitStatus) run(ctx context.Context, t cli.Telemetry) error { | |||
| statuses, err := makeStatuses(c.status) | |||
| statuses, err := model.DeploymentStatusesFromStrings(c.status) | |||
There was a problem hiding this comment.
same as the above comment 👀
|
Thanks 👍 |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
Code coverage for golang is |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: