Add the ability to trigger the deployment on changes of the specified paths #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghialv
commented
Dec 15, 2020
|
Code coverage for golang is
|
nakabonne
reviewed
Dec 15, 2020
nakabonne
reviewed
Dec 15, 2020
Comment on lines
+434
to
+440
| for _, change := range changes { | ||
| matcher, err := filematcher.NewPatternMatcher([]string{change}) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| if matcher.MatchesAny(changedFiles) { | ||
| return true, nil |
There was a problem hiding this comment.
Sorry if I'm dumb but is it needed to perform for loop? We just give all patterns to it, right?
matcher, err := filematcher.NewPatternMatcher([]string{changes})
if err != nil {
return false, err
}
if matcher.MatchesAny(changedFiles) {There was a problem hiding this comment.
We can give all patterns to filematcher and parse all of them before checking.
But by doing one by one we can have fast-return and reduce the number of unneeded regex parsing.
(In the future we can enable the regex cache too.)
There was a problem hiding this comment.
Ah, that makes sense! Okay, let's keep it as is.
|
Code coverage for golang is
|
Co-authored-by: Ryo Nakao <ryo@nakao.dev>
|
Code coverage for golang is
|
|
/lgtm |
|
Thanks 🚀 |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #979
Does this PR introduce a user-facing change?: