Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the environment ID at the environment list page #1253

Merged
merged 1 commit into from Dec 15, 2020
Merged

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:

  • use table instead of the list
  • show env ID

Screen Shot 2020-12-15 at 13 59 14

Which issue(s) this PR fixes:

Fixes #1238

Does this PR introduce a user-facing change?:

Show the environment ID at the environment list page

* use table instead of list
@nghialv nghialv changed the title Refactor environment list Show the environment ID at the environment list page Dec 15, 2020
@nghialv
Copy link
Member

nghialv commented Dec 15, 2020

Nice. Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.68%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 81.41%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit ec071ec into master Dec 15, 2020
@pipecd-bot pipecd-bot deleted the show-env-id branch December 15, 2020 05:12
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the ID field of the environment at the list page
3 participants