New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to force the sync strategy via SYNC_APPLICATION command #1264
Conversation
Code coverage for golang is
|
Code coverage for golang is
|
@nghialv We need to modify https://github.com/pipe-cd/pipe/blob/sync/pkg/app/web/src/api/applications.ts#L97-L105 export const syncApplication = async ({
applicationId,
syncStrategy, // added
}: SyncApplicationRequest.AsObject): Promise<
SyncApplicationResponse.AsObject
> => {
const req = new SyncApplicationRequest();
req.setApplicationId(applicationId);
req.setSyncStrategy(syncStrategy); // added
return apiRequest(req, apiClient.syncApplication);
}; |
@cakecatz Right. I added them. |
Code coverage for golang is
|
Code coverage for golang is
|
Code coverage for javascript is
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about the strategy name, but looks pretty neat
pkg/model/deployment.proto
Outdated
@@ -88,11 +88,18 @@ message Deployment { | |||
int64 updated_at = 102 [(validate.rules).int64.gte = 0]; | |||
} | |||
|
|||
enum SyncStrategy { | |||
NONE = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NONE
is a bit confusable to me. I feel like it would be better to use AUTO
or UNDEFINED
or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. AUTO
looks good.
/lgtm |
Code coverage for golang is
|
Code coverage for javascript is
|
/approve |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1165
Does this PR introduce a user-facing change?: