Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor insight's chart component #1466

Merged
merged 2 commits into from Jan 22, 2021
Merged

Refactor insight's chart component #1466

merged 2 commits into from Jan 22, 2021

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:

  • Update recharts.js
  • Fix chart design a little
    • remove YAxis line
    • Show year at the chart label
  • Change chart message for no data

image

image

image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@cakecatz cakecatz changed the title Refactor insight's chart component WIP: Refactor insight's chart component Jan 22, 2021
@nghialv
Copy link
Member

nghialv commented Jan 22, 2021

@cakecatz Can you fix the test?

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.33%. This pull request decreases coverage by -0.26%.

File Function Base Head Diff
pkg/app/piped/eventwatcher/eventwatcher.go NewWatcher -- 0.00% +0.00%
pkg/app/piped/eventwatcher/eventwatcher.go watcher.Run -- 0.00% +0.00%
pkg/app/piped/eventwatcher/eventwatcher.go watcher.run -- 0.00% +0.00%
pkg/app/piped/eventwatcher/eventwatcher.go watcher.updateValues -- 0.00% +0.00%
pkg/app/piped/eventwatcher/eventwatcher.go watcher.modifyFiles -- 0.00% +0.00%
pkg/app/piped/eventwatcher/eventwatcher.go convertStr -- 100.00% +100.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 86.64%. This pull request does not change code coverage.

@cakecatz cakecatz changed the title WIP: Refactor insight's chart component Refactor insight's chart component Jan 22, 2021
@cakecatz
Copy link
Contributor Author

@nghialv Fixed!

@khanhtc1202
Copy link
Member

/lgtm

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 5115588 into master Jan 22, 2021
@pipecd-bot pipecd-bot deleted the update-recharts branch January 22, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants