-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure schema on the new MySQL datastore before migrate #1813
Conversation
Code coverage for golang is
|
👍 |
BUILD.bazel
Outdated
@@ -66,6 +66,7 @@ genrule( | |||
# gazelle:exclude pkg/model/project.pb.validate.go | |||
# gazelle:exclude pkg/model/role.pb.validate.go | |||
# gazelle:exclude pkg/model/user.pb.validate.go | |||
# gazelle:exclude pkg/datastore/mysql/ensurer/sql.embed.go | |||
# gazelle:exclude pkg/app/ops/mysqlensurer/sql.embed.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 🙆♀️ addressed on 0acffcf
Code coverage for golang is
|
Thank you. |
What this PR does / why we need it:
ops/mysqlensurer
todatastore/mysql/ensurer
as sub package ofdatastore/mysql
datastore/mysql/ensurer
package fromops
andpipectl/datastore
commandWhich issue(s) this PR fixes:
Rel #1806
Does this PR introduce a user-facing change?: