Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that the form is not cleared after adding an application #1814

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1785

Does this PR introduce a user-facing change?:

Fix a bug that the form is not cleared after adding an application

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.90%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 85.26%. This pull request increases coverage by 0.01%.

File Base Head Diff
src/components/add-application-drawer/index.tsx 82.14% 82.76% +0.62%

@nghialv
Copy link
Member

nghialv commented Mar 31, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 9f33f04 into master Mar 31, 2021
@pipecd-bot pipecd-bot deleted the reset-form-after-added branch March 31, 2021 11:28
@pipecd-bot pipecd-bot mentioned this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add application form value is not reset after added an application
3 participants