Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine piped stats model #190

Merged
merged 1 commit into from Jun 24, 2020
Merged

Redefine piped stats model #190

merged 1 commit into from Jun 24, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jun 24, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Jun 24, 2020

/cc @stormcat24

@pipecd-bot pipecd-bot requested review from stormcat24 and removed request for gkuga June 24, 2020 10:07
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 24.62%. This pull request decreases coverage by -0.05%.

File Function Base Head Diff
pkg/app/piped/statsreporter/reporter.go parsePrometheusMetrics 83.33% 95.45% +12.12%

@stormcat24
Copy link
Contributor

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by stormcat24.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 19660cb into master Jun 24, 2020
@pipecd-bot pipecd-bot deleted the stats branch June 24, 2020 10:15
@pipecd-bot pipecd-bot mentioned this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants