Enable metrics flag via Helm values #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
khanhtc1202
reviewed
Jun 23, 2021
Comment on lines
101
to
103
| {{- if .Values.server.args.metrics }} | ||
| - --metrics=true | ||
| {{- end }} |
There was a problem hiding this comment.
I think - --metrics={{ .Values.server.args.metrics }} is just fine, since we have parse the value here already 👀 https://github.com/pipe-cd/pipe/blob/master/pkg/cli/app.go#L165-L171
There was a problem hiding this comment.
for sure. Piped does as well.
|
Thanks 🚀 |
|
Fixed |
|
/approve cancel |
khanhtc1202
reviewed
Jun 23, 2021
| @@ -98,6 +98,8 @@ spec: | |||
| - --enable-grpc-reflection={{ .Values.server.args.enableGRPCReflection }} | |||
| - --encryption-key-file={{ .Values.secret.mountPath }}/{{ .Values.secret.encryptionKey.fileName }} | |||
| - --log-encoding={{ .Values.server.args.logEncoding }} | |||
| - --metrics={{ .Values.server.args.metrics }} | |||
| {{- end }} | |||
There was a problem hiding this comment.
this line should be removed 🙈
|
/approve cancel |
|
Fixed |
|
🚀 |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: