Allow specifying additional labels to Piped's service manifest #2125
Conversation
|
Code coverage for golang is |
|
@gotyoooo Thank you for your pull request. |
| @@ -16,6 +16,9 @@ service: | |||
| type: ClusterIP | |||
| port: 9085 | |||
|
|
|||
| # Optional additional labels to add to the Service | |||
| # serviceLabels: {} | |||
|
|
|||
There was a problem hiding this comment.
I know in some cases, we don't want to add labels to all manifests, but just for service manifest.
How about moving this field to be an inner field of service?
service:
enabled: true
type: ClusterIP
port: 9085
additionalLabels: {}There was a problem hiding this comment.
Certainly it's better!
I will change it.
gotyoooo
force-pushed
the
Add-Values-serviceLabels-to-chart
branch
from
03ff019
to
013e6c3
Compare
gotyoooo
force-pushed
the
Add-Values-serviceLabels-to-chart
branch
from
013e6c3
to
3aa1056
Compare
nghialv
changed the title
|
Thank you. |
|
Nice, thx |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
Code coverage for golang is |
What this PR does / why we need it:
Change to be able to add optional labels to the pipe service.
Labels are useful because they may be used for purposes other than those used by Piped.
If necessary, add it to pipecd, site, but how about it?
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: