Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dependency-update flag to fetch dependencies before installing quickstart #2135

Merged
merged 1 commit into from Jun 25, 2021

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jun 25, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nakabonne
Copy link
Member

Right. When installing from local charts, it's needed.
/lgtm

@khanhtc1202
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.45%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit f488bd5 into master Jun 25, 2021
@pipecd-bot pipecd-bot deleted the quickstart branch June 25, 2021 08:24
pipecd-bot pushed a commit that referenced this pull request Jul 14, 2021
**What this PR does / why we need it**:
It's also needed here as well as #2135

**Which issue(s) this PR fixes**:

Fixes #

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants