Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fake client for Piped service #2492

Merged
merged 3 commits into from Sep 17, 2021
Merged

Remove fake client for Piped service #2492

merged 3 commits into from Sep 17, 2021

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Remove the "--use-fake-api-client" option from Piped

@nghialv
Copy link
Member

nghialv commented Sep 17, 2021

/lgtm

@pipecd-bot pipecd-bot removed the lgtm label Sep 17, 2021
@khanhtc1202
Copy link
Member

khanhtc1202 commented Sep 17, 2021 •
edited

@nakabonne We have it here too (in manifest)
https://github.com/pipe-cd/pipe/blob/master/manifests/piped/templates/deployment.yaml#L33
https://github.com/pipe-cd/pipe/blob/master/manifests/piped/values.yaml#L6

@nakabonne
Copy link
Member Author

Right

@nakabonne nakabonne changed the title Remove fake client for Piped service [WIP] Remove fake client for Piped service Sep 17, 2021
@nakabonne
Copy link
Member Author

I make clean-ed just now so just a moment

@nakabonne nakabonne changed the title [WIP] Remove fake client for Piped service Remove fake client for Piped service Sep 17, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.84%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Sep 17, 2021

/llgtm

@khanhtc1202
Copy link
Member

すっきりした 😌
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit aadb3e1 into master Sep 17, 2021
@pipecd-bot pipecd-bot deleted the remove-fakeclient branch September 17, 2021 06:07
@pipecd-bot pipecd-bot mentioned this pull request Sep 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202 khanhtc1202 is a code owner

@nghialv nghialv Awaiting requested review from nghialv nghialv is a code owner

Assignees
No one assigned
Labels
approved area/api area/manifests area/piped size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nakabonne @nghialv @khanhtc1202 @pipecd-bot