Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment chain RFC #2743

Merged
merged 15 commits into from
Nov 10, 2021
Merged

Add deployment chain RFC #2743

merged 15 commits into from
Nov 10, 2021

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Nov 4, 2021

Still reading the RFC but just left some quick reviews.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Nov 5, 2021

It would be nice if you can add a screenshot of a simple mock page of the "Flows" or "Chains" tab.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@khanhtc1202 khanhtc1202 changed the title Add deployment flow RFC Add deployment chain RFC Nov 5, 2021
@khanhtc1202
Copy link
Member Author

Thanks @nghialv @nakabonne, PTAL when you guys have time 🙆‍♀️

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

docs/rfcs/0007-deployment-chain.md Outdated Show resolved Hide resolved
docs/rfcs/0007-deployment-chain.md Outdated Show resolved Hide resolved
khanhtc1202 and others added 2 commits November 8, 2021 12:26
Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>
Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

Use-case <1>: chain of deployments contains multiple application cross kinds

Another typical use-case is when users want to build up some kind of chain such as deploy application to the development environment, then if it's done successfully, deploy that application to the staging and then the production environment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about following the layout below to be easier to read?

Use-case <1> ...
Image 1
Description text for use-case 1

Use-case <2> ...
Image 2
Description text for use-case 2


Use-case <3> ...
Image 3
Description text for use-case 3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adopted 🙆‍♀️


Or a variant of that requirement, when users want to roll out their applications to their cluster one by one based on its region. As the same below image, the order of the rolling out deployment should be flex, supports both sequential and parallel.

![image](assets/deployment-chain-region.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the application names in this image should be fixed as application-x-region-a, application-x-region-b, ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed by b16dee1

Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Nov 9, 2021

Finally, we can see a nice future for the deployment chain feature.
Great write-up.
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Nov 9, 2021
@nakabonne
Copy link
Member

I'm sure this will blow their mind!
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 751b16a into master Nov 10, 2021
@pipecd-bot pipecd-bot deleted the add-deployment-flow-rfc branch November 10, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants