-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment chain RFC #2743
Add deployment chain RFC #2743
Conversation
Still reading the RFC but just left some quick reviews. |
It would be nice if you can add a screenshot of a simple mock page of the "Flows" or "Chains" tab. |
Thanks @nghialv @nakabonne, PTAL when you guys have time 🙆♀️ |
Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>
Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>
…o add-deployment-flow-rfc
Use-case <1>: chain of deployments contains multiple application cross kinds | ||
|
||
Another typical use-case is when users want to build up some kind of chain such as deploy application to the development environment, then if it's done successfully, deploy that application to the staging and then the production environment. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about following the layout below to be easier to read?
Use-case <1> ...
Image 1
Description text for use-case 1
Use-case <2> ...
Image 2
Description text for use-case 2
Use-case <3> ...
Image 3
Description text for use-case 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adopted 🙆♀️
|
||
Or a variant of that requirement, when users want to roll out their applications to their cluster one by one based on its region. As the same below image, the order of the rolling out deployment should be flex, supports both sequential and parallel. | ||
|
||
![image](assets/deployment-chain-region.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the application names in this image should be fixed as application-x-region-a
, application-x-region-b
, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed by b16dee1
Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>
Finally, we can see a nice future for the deployment chain feature. |
I'm sure this will blow their mind! |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: