Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise lambda application configuration test data #2760

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/config/deployment_lambda_test.go
--- pkg/config/deployment_lambda_test.go.orig
+++ pkg/config/deployment_lambda_test.go
@@ -18,9 +18,10 @@
 	"testing"
 	"time"
 
-	"github.com/pipe-cd/pipe/pkg/model"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/pipe-cd/pipe/pkg/model"
 )
 
 func TestLambdaDeploymentConfig(t *testing.T) {

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.15%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/config/deployment.go PipelineStage.UnmarshalJSON 34.15% 40.24% +6.10%

@khanhtc1202
Copy link
Member Author

/golinter fmt

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.15%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/config/deployment.go PipelineStage.UnmarshalJSON 34.15% 40.24% +6.10%

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit b5913b5 into master Nov 8, 2021
@pipecd-bot pipecd-bot deleted the revise-config-lambda-test branch November 8, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants