Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded TODO comment #2773

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Remove unneeded TODO comment #2773

merged 1 commit into from
Nov 10, 2021

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:
We settled on letting Piped watch application configs in Git, even unregistered ones as well.

Which issue(s) this PR fixes:

Fixes #2753

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202
Copy link
Member

Nice catch
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.09%. This pull request decreases coverage by -0.02%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/terraform/terraform.go WithAdditionalEnvs -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go Determiner.shouldTriggerOnCommit -- 0.00% +0.00%
pkg/model/application.go Application.ContainLabels -- 77.78% +77.78%
pkg/model/deployment.go Deployment.ContainLabels -- 77.78% +77.78%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Init 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.SelectWorkspace 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Plan 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Apply 0.00% 0.00% +0.00%
pkg/app/piped/trigger/determiner.go Determiner.ShouldTrigger 0.00% 0.00% +0.00%
pkg/config/deployment.go PipelineStage.UnmarshalJSON 34.15% 40.24% +6.10%
pkg/app/api/grpcapi/web_api.go WebAPI.UpdateApplication 0.00% 0.00% +0.00%
pkg/app/launcher/cmd/launcher/binary.go command.GracefulStop 66.67% 100.00% +33.33%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Version 0.00% 0.00% +0.00%
pkg/model/application.go Application.ContainTags 88.89% -- -88.89%
pkg/model/deployment.go Deployment.ContainTags 88.89% -- -88.89%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a command to send an application information defined in the application config
3 participants