Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TriggeredDeploymentID metadata key to command model #2800

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Nov 18, 2021

What this PR does / why we need it:

triggeredDeploymentIDKey used in both trigger(piped) and pipectl but must be defined to use could lead to unexpected error in case the key name changed in one end. This PR moves the key to the Command model (since it is the key in command metadata) and explicitly refers it in the used end.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

pkg/model/command.go Show resolved Hide resolved
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.91%. This pull request does not change code coverage.

@nakabonne
Copy link
Member

Even if the size of PR is tiny, It would help us to understand what context is behind that if you could write a short note in the PR body. Just a little bit is enough 🙏

@khanhtc1202
Copy link
Member Author

Even if the size of PR is tiny, It would help us to understand what context is behind that if you could write a short note in the PR body. Just a little bit is enough 🙏

Sure, updated the PR description 🙏

@nakabonne
Copy link
Member

Thank you. Looks neat!
/lgtm

@nghialv
Copy link
Member

nghialv commented Nov 18, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 7c6c5e1 into master Nov 18, 2021
@pipecd-bot pipecd-bot deleted the move-triggered-deployment-id-key branch November 18, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants