Check and show health state of K8s Namespace resource

[ono-max]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1610

Does this PR introduce a user-facing change?:

NONE

[pipecd-bot]

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/app/piped/cloudprovider/kubernetes/state.go

--- pkg/app/piped/cloudprovider/kubernetes/state.go.orig
+++ pkg/app/piped/cloudprovider/kubernetes/state.go
@@ -560,15 +560,15 @@
 	status = model.KubernetesResourceState_HEALTHY
 
 	var cond *corev1.NamespaceCondition
-	L:
-		for i := range ns.Status.Conditions {
-			c := ns.Status.Conditions[i]
-			switch c.Type {
-			case corev1.NamespaceDeletionDiscoveryFailure, corev1.NamespaceDeletionContentFailure, corev1.NamespaceDeletionGVParsingFailure:
-				cond = &c
-				break L
-			}
+L:
+	for i := range ns.Status.Conditions {
+		c := ns.Status.Conditions[i]
+		switch c.Type {
+		case corev1.NamespaceDeletionDiscoveryFailure, corev1.NamespaceDeletionContentFailure, corev1.NamespaceDeletionGVParsingFailure:
+			cond = &c
+			break L
 		}
+	}
 
 	if cond != nil && cond.Status == corev1.ConditionTrue {
 		status = model.KubernetesResourceState_OTHER

[pipecd-bot]

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

[pipecd-bot]

Code coverage for golang is 31.78%. This pull request decreases coverage by -0.05%.

File	Function	Base	Head	Diff
pkg/app/piped/cloudprovider/kubernetes/state.go	determineNameSpace	--	0.00%	+0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go	determineResourceHealth	0.00%	0.00%	+0.00%

[pipecd-bot]

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

[pipecd-bot]

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

[pipecd-bot]

Code coverage for golang is 31.78%. This pull request decreases coverage by -0.06%.

File	Function	Base	Head	Diff
pkg/app/piped/cloudprovider/kubernetes/state.go	determineNameSpace	--	0.00%	+0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go	determineResourceHealth	0.00%	0.00%	+0.00%

[pipecd-bot]

Code coverage for golang is 31.78%. This pull request decreases coverage by -0.06%.

File	Function	Base	Head	Diff
pkg/app/piped/cloudprovider/kubernetes/state.go	determineNameSpace	--	0.00%	+0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go	determineResourceHealth	0.00%	0.00%	+0.00%

[nghialv]

Just left the last nit.
/lgtm

[pipecd-bot]

Code coverage for golang is 31.78%. This pull request decreases coverage by -0.06%.

File	Function	Base	Head	Diff
pkg/app/piped/cloudprovider/kubernetes/state.go	determineNameSpace	--	0.00%	+0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go	determineResourceHealth	0.00%	0.00%	+0.00%

[nghialv]

/lgtm

[nakabonne]

Way to go!
/approve

[pipecd-bot]

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.