Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint settings #357

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Update golangci-lint settings #357

merged 1 commit into from
Jul 9, 2020

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:
Linters that require to preload Go packages are now available on Piped project.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 24.14%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Jul 9, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 91aaf96 into master Jul 9, 2020
@pipecd-bot pipecd-bot deleted the golangci-lint branch July 9, 2020 08:57
@pipecd-bot pipecd-bot mentioned this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants