Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required to piped name on the piped register form #362

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:

image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nakabonne
Copy link
Member

/lgtm

@nghialv
Copy link
Member

nghialv commented Jul 10, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.93%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit 109484e into master Jul 10, 2020
@pipecd-bot pipecd-bot deleted the require-piped-name branch July 10, 2020 03:06
@cakecatz cakecatz self-assigned this Jul 10, 2020
@pipecd-bot pipecd-bot mentioned this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants