Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support traffic routing for non-mesh application #379

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 12, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #377

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Jul 12, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.79%. This pull request decreases coverage by -0.15%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/kubernetes/manifest.go Manifest.AddStringMapValues -- 0.00% +0.00%
pkg/app/piped/executor/kubernetes/traffic.go Executor.ensurePodTrafficRouting 0.00% 0.00% +0.00%

@pipecd-bot pipecd-bot merged commit 86b4abb into master Jul 12, 2020
@pipecd-bot pipecd-bot deleted the traffic-routing branch July 12, 2020 15:46
@pipecd-bot pipecd-bot mentioned this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement TRAFFIC_ROUTING for non-mesh application
2 participants