Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded code for detemining resource state #386

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 13, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

/cc @nakabonne

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.87%. This pull request increases coverage by 0.08%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/kubernetes/state.go determineConfigMapHealth 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineSecretHealth 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineServiceAccountHealth 0.00% 0.00% +0.00%

@nakabonne
Copy link
Member

I also thought it's unneeded converting, but it can give us the least amount of validation, by converting to the struct provided by the official API.

@nakabonne
Copy link
Member

Because of that, I appended that logic.

@nghialv
Copy link
Member Author

nghialv commented Jul 13, 2020

We are converting from the data got from the Kubernetes API.
That data was already validated while applying to the Kubernetes by the Kubernetes API server.
So we don't need that second check.

@nakabonne
Copy link
Member

Ah, I was not sure that, now I can approve without hesitation.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 2383a82 into master Jul 13, 2020
@pipecd-bot pipecd-bot deleted the state branch July 13, 2020 03:01
@pipecd-bot pipecd-bot mentioned this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants