Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move notification configuration to be a part of piped notification #457

Merged
merged 1 commit into from Jul 17, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 17, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

/cc @nakabonne

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.92%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/config/config.go Config.init 70.59% 80.00% +9.41%
pkg/config/notification.go NotificationSpec.Validate 0.00% -- +-0.00%

@nakabonne
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 6cd1829 into master Jul 17, 2020
@pipecd-bot pipecd-bot deleted the notification branch July 17, 2020 03:20
@pipecd-bot pipecd-bot mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants