Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor kubernetes executors #472

Merged
merged 1 commit into from Jul 17, 2020
Merged

Refactor kubernetes executors #472

merged 1 commit into from Jul 17, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 17, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Jul 17, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 23.09%. This pull request increases coverage by 0.22%.

File Function Base Head Diff
pkg/app/piped/executor/kubernetes/baseline.go Executor.removeBaselineResources 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/canary.go Executor.removeCanaryResources 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/traffic.go Executor.generateTrafficRoutingManifest 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/kubernetes.go makeSuffixedName 66.67% 100.00% +33.33%
pkg/app/piped/executor/kubernetes/traffic.go Executor.ensureTrafficRouting 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/traffic.go generateVirtualServiceManifest 88.46% 86.21% -2.25%
pkg/app/piped/executor/kubernetes/traffic.go generateVirtualServiceManifestV1Alpha3 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/manifest.go Manifest.Duplicate 0.00% 100.00% +100.00%
pkg/app/piped/executor/kubernetes/kubernetes.go Executor.deleteResources 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/kubernetes.go duplicateManifest 0.00% 100.00% +100.00%

@pipecd-bot pipecd-bot merged commit f2c971c into master Jul 17, 2020
@pipecd-bot pipecd-bot deleted the kubernetes-executor branch July 17, 2020 13:13
@pipecd-bot pipecd-bot mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants