Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Kubernetes rollback should delete resources of other variants even when prune was not specified #473

Merged
merged 1 commit into from Jul 17, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 17, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #456

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Jul 17, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.97%. This pull request decreases coverage by -0.11%.

File Function Base Head Diff
pkg/app/piped/executor/kubernetes/rollback.go Executor.ensureRollback -- 0.00% +0.00%
pkg/app/piped/executor/kubernetes/sync.go Executor.ensureSync 0.00% 0.00% +0.00%

@pipecd-bot pipecd-bot merged commit 66d1a84 into master Jul 17, 2020
@pipecd-bot pipecd-bot deleted the kubernetes-rollback branch July 17, 2020 13:29
@pipecd-bot pipecd-bot mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes rollback should delete resources of other variants even when "prune" was not specified
2 participants