Fix to check all canary resources are deleted #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage for golang is
|
nghialv
reviewed
Jul 20, 2020
| @@ -94,6 +94,7 @@ func (e *Executor) ensureCanaryClean(ctx context.Context) model.StageStatus { | |||
|
|
|||
| resources := strings.Split(value, ",") | |||
| if err := e.removeCanaryResources(ctx, resources); err != nil { | |||
| e.LogPersister.AppendErrorf("Unable to remove canary resources: %v", err) | |||
There was a problem hiding this comment.
Can you add this log for baseline too?
nghialv
reviewed
Jul 20, 2020
| return fmt.Errorf("unable to delete %d resources", len(resources)-deletedCount) | ||
| if deletedCount < resourcesLen { | ||
| e.LogPersister.AppendInfof("Deleted %d/%d resources", deletedCount, resourcesLen) | ||
| return fmt.Errorf("unable to delete %d resources", resourcesLen-deletedCount) |
|
Code coverage for golang is
|
|
Fixed |
|
/approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #478
Does this PR introduce a user-facing change?: