Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to order lists by UpdatedAt #527

Merged
merged 1 commit into from Jul 27, 2020
Merged

Ensure to order lists by UpdatedAt #527

merged 1 commit into from Jul 27, 2020

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #470

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.14%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/app/api/api/web_api.go WebAPI.ListApplications 0.00% 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.ListDeployments 0.00% 0.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Jul 27, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 7816c89 into master Jul 27, 2020
@pipecd-bot pipecd-bot deleted the order-update branch July 27, 2020 00:36
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that ListApplications and ListDeployments returns the list in order by updatedAt
3 participants