Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pagination for Deployments #532

Merged
merged 3 commits into from Jul 29, 2020
Merged

Support pagination for Deployments #532

merged 3 commits into from Jul 29, 2020

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #368

Does this PR introduce a user-facing change?:

NONE

pkg/app/web/src/modules/deployments.ts Outdated Show resolved Hide resolved
Co-authored-by: Ryo Narita <mail.ryonarita@gmail.com>
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.13%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/app/api/api/web_api.go WebAPI.ListDeployments 0.00% 0.00% +0.00%

@nakabonne
Copy link
Member Author

Fixed

@cakecatz
Copy link
Contributor

/lgtm

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.73%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/app/api/api/web_api.go WebAPI.ListDeployments 0.00% 0.00% +0.00%

@nakabonne
Copy link
Member Author

Resolved the conflict.
@nghialv Are you still worried about #368 (comment)? If so, I'll glad to /hold this PR for now.

@nghialv
Copy link
Member

nghialv commented Jul 29, 2020

Yes, I was concerned about that. But It is not worth the effort for now.
The completed deployment will not be updated.
So I think this solution is good enough at this time and let's merge this PR.

(After adding the support for MongoDB and DynamoDB we can reinvestigate about the pagination for all of them or can see how to run multiple queries with the same snapshot.)

@nghialv
Copy link
Member

nghialv commented Jul 29, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit c25c652 into master Jul 29, 2020
@pipecd-bot pipecd-bot deleted the pagination branch July 29, 2020 02:29
@nakabonne
Copy link
Member Author

Got it.

(After adding the support for MongoDB and DynamoDB we can reinvestigate about the pagination for all of them or can see how to run multiple queries with the same snapshot.)

Absolutely.

@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pagination for Deployment list
4 participants