Implement an infinite loading for the deployment list page #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakecatz
changed the title
cakecatz
force-pushed
the
deployment-paging
branch
from
2273ef2
to
11c62ec
Compare
|
Code coverage for golang is |
nghialv
reviewed
Jul 29, 2020
|
|
||
| export type Deployment = Required<DeploymentModel.AsObject>; | ||
| export type Stage = Required<PipelineStage.AsObject>; | ||
| export type DeploymentStatusKey = keyof typeof DeploymentStatus; | ||
|
|
||
| const ITEMS_PER_PAGE = 30; | ||
| const ITEMS_PER_PAGE = 50; | ||
| const FETCH_MORE_ITEMS_PER_PAGE = 30; |
There was a problem hiding this comment.
１回目（開く時）の数は50, ２回目から（load more)３０ですね。
nghialv
reviewed
Jul 29, 2020
| >("deployments/fetchMoreList", async (_, thunkAPI) => { | ||
| const { deployments, deploymentFilterOptions } = thunkAPI.getState(); | ||
| const lastItem = selectLastItem(deployments); | ||
| const maxUpdatedAt = lastItem ? lastItem.updatedAt : 0; |
|
Thank you. |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
failed to handle template rule examples Details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: