Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the new piped pod should be initialized only after the old one was terminated #561

Merged
merged 1 commit into from Jul 29, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 29, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.76%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/config/deployment_kubernetes.go KubernetesDeploymentSpec.GetStage -- 0.00% +0.00%
pkg/config/deployment_kubernetes.go KubernetesDeploymentSpec.Validate -- 100.00% +100.00%
pkg/config/deployment_kubernetes.go DetermineTrafficRoutingMethod -- 0.00% +0.00%
pkg/config/deployment_kubernetes.go K8sTrafficRoutingStageOptions.Percentages -- 0.00% +0.00%
pkg/config/deployment_terraform.go TerraformDeploymentSpec.GetStage -- 0.00% +0.00%
pkg/config/deployment_terraform.go TerraformDeploymentSpec.Validate -- 100.00% +100.00%
pkg/config/deployment.go KubernetesDeploymentSpec.GetStage 0.00% -- +-0.00%
pkg/config/deployment.go KubernetesDeploymentSpec.Validate 100.00% -- -100.00%
pkg/config/deployment.go TerraformDeploymentSpec.GetStage 0.00% -- +-0.00%
pkg/config/deployment.go TerraformDeploymentSpec.Validate 100.00% -- -100.00%
pkg/config/deployment.go DetermineTrafficRoutingMethod 0.00% -- +-0.00%
pkg/config/deployment.go K8sTrafficRoutingStageOptions.Percentages 0.00% -- +-0.00%

@nghialv
Copy link
Member Author

nghialv commented Jul 29, 2020

/cc @cakecatz

@pipecd-bot pipecd-bot requested a review from cakecatz July 29, 2020 09:23
@cakecatz
Copy link
Contributor

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by cakecatz.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 57b9b89 into master Jul 29, 2020
@pipecd-bot pipecd-bot deleted the piped-manifest branch July 29, 2020 09:41
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants