Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored project model #668

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Refactored project model #668

merged 1 commit into from
Aug 20, 2020

Conversation

gkuga
Copy link
Contributor

@gkuga gkuga commented Aug 20, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

pkg/app/api/api/fake_web_api.go Show resolved Hide resolved
pkg/app/api/api/fake_web_api.go Show resolved Hide resolved
pkg/app/api/api/fake_web_api.go Show resolved Hide resolved
pkg/app/api/api/fake_web_api.go Show resolved Hide resolved
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.59%. This pull request decreases coverage by -0.04%.

File Function Base Head Diff
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectSSOConfig -- 0.00% +0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectRBACConfig -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectSSOConfig -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectRBACConfig -- 0.00% +0.00%
pkg/datastore/projectstore.go projectStore.UpdateProjectSSOConfig -- 0.00% +0.00%
pkg/datastore/projectstore.go projectStore.UpdateProjectRBACConfig -- 0.00% +0.00%
pkg/model/project.go ProjectRBACConfig.Update -- 100.00% +100.00%
pkg/model/project.go ProjectSSOConfig.RedactSensitiveData -- 100.00% +100.00%
pkg/model/project.go ProjectSSOConfig.Update -- 100.00% +100.00%
pkg/model/project.go ProjectSSOConfig.GenerateAuthCodeURL -- 0.00% +0.00%
pkg/model/project.go ProjectSSOConfig_GitHub.RedactSensitiveData -- 100.00% +100.00%
pkg/model/project.go ProjectSSOConfig_GitHub.Update -- 100.00% +100.00%
pkg/model/project.go ProjectSSOConfig_GitHub.GenerateAuthCodeURL -- 0.00% +0.00%
pkg/oauth/github/github.go OAuthClient.decideRole 94.12% 94.44% +0.33%
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectSingleSignOn 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectSingleSignOn 0.00% -- +-0.00%
pkg/config/deployment_lambda.go LambdaTrafficRoutingStageOptions.Percentages 0.00% -- +-0.00%
pkg/datastore/projectstore.go projectStore.UpdateProjectSingleSignOn 0.00% -- +-0.00%
pkg/model/project.go ProjectSingleSignOn.RedactSensitiveData 100.00% -- -100.00%
pkg/model/project.go ProjectSingleSignOn.Update 100.00% -- -100.00%
pkg/model/project.go ProjectSingleSignOn.GenerateAuthCodeURL 0.00% -- +-0.00%
pkg/model/project.go ProjectSingleSignOn_GitHub.RedactSensitiveData 100.00% -- -100.00%
pkg/model/project.go ProjectSingleSignOn_GitHub.Update 100.00% -- -100.00%
pkg/model/project.go ProjectSingleSignOn_GitHub.GenerateAuthCodeURL 0.00% -- +-0.00%

@nghialv
Copy link
Member

nghialv commented Aug 20, 2020

Nice. Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 8c4a366 into master Aug 20, 2020
@pipecd-bot pipecd-bot deleted the project branch August 20, 2020 09:33
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants