Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check error type #699

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Don't check error type #699

merged 1 commit into from
Aug 26, 2020

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:
The check should be done by the caller of stageLogFileStore.Get.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.38%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/app/api/stagelogstore/filestore.go stageLogFileStore.Get 90.91% 95.45% +4.55%

@nghialv
Copy link
Member

nghialv commented Aug 26, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 8e02da6 into master Aug 26, 2020
@pipecd-bot pipecd-bot deleted the check-errors branch August 26, 2020 07:11
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants