Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong diff result while comparing a zero map to a nil map #760

Merged
merged 1 commit into from Sep 8, 2020
Merged

Fix wrong diff result while comparing a zero map to a nil map #760

merged 1 commit into from Sep 8, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Sep 8, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #756

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.05%. This pull request increases coverage by 0.09%.

File Function Base Head Diff
pkg/app/piped/diff/diff.go isEmptyInterface -- 87.50% +87.50%
pkg/app/piped/diff/diff.go differ.diffInterface 60.00% 71.43% +11.43%

nakabonne
nakabonne approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 1eeb179 into master Sep 8, 2020
@pipecd-bot pipecd-bot deleted the diff branch September 8, 2020 03:13
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details 
Error: unabled to push rendered files to destination

This was referenced Sep 9, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakabonne nakabonne nakabonne approved these changes

@stormcat24 stormcat24 Awaiting requested review from stormcat24

Assignees
No one assigned
Labels
approved area/piped release-note-none size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diff algorithm shows a wrong sync result
3 participants
@nghialv @pipecd-bot @nakabonne