Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs: add guide to add env and piped, update control-plane installation guide #899

Merged
merged 2 commits into from Oct 2, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Oct 2, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv nghialv changed the title Update docs: add guide to add env and piped, update control-plane Update docs: add guide to add env and piped, update control-plane installation guide Oct 2, 2020
@nghialv
Copy link
Member Author

nghialv commented Oct 2, 2020

/cc @nakabonne

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 23.63%. This pull request does not change code coverage.

@gkuga
Copy link
Contributor

gkuga commented Oct 2, 2020

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Oct 2, 2020
…nvironment.md

Co-authored-by: Ryo Nakao <ryo@nakao.dev>
@pipecd-bot pipecd-bot removed the lgtm label Oct 2, 2020
@nakabonne
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 23.63%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit 4c0c110 into master Oct 2, 2020
@pipecd-bot pipecd-bot deleted the docs branch October 2, 2020 05:38
@pipecd-bot pipecd-bot mentioned this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants