Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an alternative command for generating the encryption key #901

Merged
merged 2 commits into from Oct 5, 2020
Merged

Conversation

gkuga
Copy link
Contributor

@gkuga gkuga commented Oct 5, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 23.95%. This pull request does not change code coverage.

@@ -29,6 +29,9 @@ PipeCD requires a key for encrypting sensitive data or signing JWT token while a

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"You can use one of the following commands to generate an encryption key."

@@ -29,6 +29,9 @@ PipeCD requires a key for encrypting sensitive data or signing JWT token while a

``` console
openssl rand 64 -out encryption-key

# If it doesn't work, this one is also OK.
Copy link
Member

@nghialv nghialv Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# or

@nghialv nghialv changed the title Add another command that generates random bytes Add an alternative command for generating the encryption key Oct 5, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 23.95%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Oct 5, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 8ff78b2 into master Oct 5, 2020
@pipecd-bot pipecd-bot deleted the doc branch October 5, 2020 02:41
@pipecd-bot pipecd-bot mentioned this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants