Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the add application form #911

Merged
merged 1 commit into from Oct 5, 2020
Merged

Conversation

cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Oct 5, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 23.95%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 67.80%. This pull request increases coverage by 1.56%.

File Base Head Diff
src/components/add-application-form.tsx -- 92.45% +92.45%
src/constants/ui-text.ts -- 100.00% +100.00%
src/api/applications.ts 21.43% 21.05% -0.38%
src/modules/pipeds.ts 50.00% 53.57% +3.57%

@nghialv
Copy link
Member

nghialv commented Oct 5, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit f4556ad into master Oct 5, 2020
@pipecd-bot pipecd-bot deleted the refactor-add-application branch October 5, 2020 08:25
@pipecd-bot pipecd-bot mentioned this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants