Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web tests #929

Merged
merged 1 commit into from Oct 7, 2020
Merged

Add web tests #929

merged 1 commit into from Oct 7, 2020

Conversation

cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Oct 7, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@cakecatz cakecatz changed the title Add component tests Add web tests Oct 7, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 25.94%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 69.00%. This pull request increases coverage by 1.20%.

File Base Head Diff
src/components/approval-stage.tsx 55.56% 100.00% +44.44%
src/components/deployment-status-icon.tsx 71.43% 100.00% +28.57%
src/utils/use-interval.ts 66.67% 100.00% +33.33%

@nghialv
Copy link
Member

nghialv commented Oct 7, 2020

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit d1906af into master Oct 7, 2020
@pipecd-bot pipecd-bot deleted the add-tests branch October 7, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants