Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secrets management feature to feature status #931

Merged
merged 1 commit into from Oct 8, 2020
Merged

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Oct 8, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Oct 8, 2020

/cc @nakabonne

Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 25.94%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit ed9cd2b into master Oct 8, 2020
@pipecd-bot pipecd-bot deleted the docs branch October 8, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants