Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor crypto package #954

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Refactor crypto package #954

merged 1 commit into from
Oct 13, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Oct 13, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

/cc @gkuga

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 26.23%. This pull request decreases coverage by -0.05%.

File Function Base Head Diff
pkg/crypto/aes.go NewAESEncryptDecrypter -- 83.33% +83.33%
pkg/crypto/aes.go AESEncryptDecrypter.Encrypt -- 76.92% +76.92%
pkg/crypto/aes.go AESEncryptDecrypter.Decrypt -- 71.43% +71.43%
pkg/crypto/decrypter.go NewDecrypter 83.33% -- -83.33%
pkg/crypto/decrypter.go decrypter.Decrypt 71.43% -- -71.43%
pkg/crypto/encrypter.go NewEncrypter 83.33% -- -83.33%
pkg/crypto/encrypter.go encrypter.Encrypt 76.92% -- -76.92%

@gkuga
Copy link
Contributor

gkuga commented Oct 13, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by gkuga.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants