Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources as piped's default value #961

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:
This aims to make it clear that the resource can be specified.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 26.35%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Oct 14, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit ff12a6e into master Oct 14, 2020
@pipecd-bot pipecd-bot deleted the piped-resources branch October 14, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants