Emit target namespace on the stage log #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed while validating Kapetanios configuration. Details |
nghialv
reviewed
Oct 19, 2020
| @@ -189,7 +189,7 @@ func (e *Executor) addBuiltinAnnontations(manifests []provider.Manifest, variant | |||
| } | |||
|
|
|||
| func (e *Executor) applyManifests(ctx context.Context, manifests []provider.Manifest) error { | |||
| e.LogPersister.Infof("Start applying %d manifests", len(manifests)) | |||
| e.LogPersister.Infof("Start applying %d manifests to %q namespace", len(manifests), e.config.Input.Namespace) | |||
There was a problem hiding this comment.
What will be logged when the Input.Namespace was not specified?
There was a problem hiding this comment.
You're quite right. Can't really say which namespace this applies to, so make sure to show when only specified.
|
Code coverage for golang is |
|
Code coverage for golang is
|
|
Thank you. |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The below log shows the contents of the manifest, so it appears to be correct:
Instead, I appended target namespace info to another log.
Which issue(s) this PR fixes:
Fixes #969
Does this PR introduce a user-facing change?: