Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable decrypting the sealed secrets at piped #973

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Enable decrypting the sealed secrets at piped #973

merged 2 commits into from
Oct 19, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Oct 19, 2020

What this PR does / why we need it:

In the next pull requests:

  • more test for secrets management feature
  • improve the visibility of the sealed secret

Which issue(s) this PR fixes:

Part of #749

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Oct 19, 2020

/cc @nakabonne

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 26.22%. This pull request decreases coverage by -0.10%.

File Function Base Head Diff
pkg/app/piped/controller/controller.go decryptSealedSecrets -- 0.00% +0.00%
pkg/config/config.go Config.GetGenericDeployment -- 0.00% +0.00%
pkg/config/deployment.go GenericDeploymentSpec.GetStage -- 0.00% +0.00%
pkg/app/piped/controller/planner.go planner.Run 0.00% 0.00% +0.00%
pkg/app/piped/controller/scheduler.go scheduler.ensurePreparing 0.00% 0.00% +0.00%
pkg/config/config.go Config.GetPipelineable 0.00% -- +-0.00%
pkg/config/deployment_cloudrun.go CloudRunDeploymentSpec.GetStage 0.00% -- +-0.00%
pkg/config/deployment_kubernetes.go KubernetesDeploymentSpec.GetStage 0.00% -- +-0.00%
pkg/config/deployment_lambda.go LambdaDeploymentSpec.GetStage 0.00% -- +-0.00%
pkg/config/deployment_terraform.go TerraformDeploymentSpec.GetStage 0.00% -- +-0.00%

@nakabonne
Copy link
Member

Except for just one nit, looks good to me. A big thank you goes out to you!

Co-authored-by: Ryo Nakao <ryo@nakao.dev>
@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 26.22%. This pull request decreases coverage by -0.10%.

File Function Base Head Diff
pkg/app/piped/controller/controller.go decryptSealedSecrets -- 0.00% +0.00%
pkg/config/config.go Config.GetGenericDeployment -- 0.00% +0.00%
pkg/config/deployment.go GenericDeploymentSpec.GetStage -- 0.00% +0.00%
pkg/app/piped/controller/scheduler.go scheduler.ensurePreparing 0.00% 0.00% +0.00%
pkg/app/piped/controller/planner.go planner.Run 0.00% 0.00% +0.00%
pkg/config/config.go Config.GetPipelineable 0.00% -- +-0.00%
pkg/config/deployment_cloudrun.go CloudRunDeploymentSpec.GetStage 0.00% -- +-0.00%
pkg/config/deployment_kubernetes.go KubernetesDeploymentSpec.GetStage 0.00% -- +-0.00%
pkg/config/deployment_lambda.go LambdaDeploymentSpec.GetStage 0.00% -- +-0.00%
pkg/config/deployment_terraform.go TerraformDeploymentSpec.GetStage 0.00% -- +-0.00%

@pipecd-bot pipecd-bot merged commit 8513017 into master Oct 19, 2020
@pipecd-bot pipecd-bot deleted the secrets branch October 19, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants