Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use skelton component for the loading indicator of application detail #974

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:

image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Show Skeleton instead of CircularProgress for the application live state text

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 26.32%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 78.20%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Oct 19, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit e3b4e31 into master Oct 19, 2020
@pipecd-bot pipecd-bot deleted the use-skelton branch October 19, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants