Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a hybrid encryption to process a bigger message size #981

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Add a hybrid encryption to process a bigger message size #981

merged 2 commits into from
Oct 20, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Oct 20, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #980

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Oct 20, 2020

/cc @nakabonne

pipecd-bot
pipecd-bot reviewed Oct 20, 2020
View reviewed changes
Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

pkg/crypto/hybrid.go Outdated Show resolved Hide resolved
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 26.95%. This pull request increases coverage by 0.33%.

File Function Base Head Diff
pkg/crypto/hybrid.go NewHybridEncrypter -- 75.00% +75.00%
pkg/crypto/hybrid.go HybridEncrypter.Encrypt -- 77.78% +77.78%
pkg/crypto/hybrid.go NewHybridDecrypter -- 75.00% +75.00%
pkg/crypto/hybrid.go HybridDecrypter.Decrypt -- 70.83% +70.83%

nakabonne
nakabonne approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty neat:-D

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit d3874b8 into master Oct 20, 2020
@pipecd-bot pipecd-bot deleted the crypto branch October 20, 2020 05:22
@pipecd-bot pipecd-bot mentioned this pull request Oct 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pipecd-bot pipecd-bot pipecd-bot left review comments

@nakabonne nakabonne nakabonne approved these changes

@cakecatz cakecatz Awaiting requested review from cakecatz

@gkuga gkuga Awaiting requested review from gkuga

Assignees
No one assigned
Labels
approved area/api area/piped release-note-none size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a hybrid scheme of the secret encryption to encrypt reasonable amounts of data
3 participants
@nghialv @pipecd-bot @nakabonne